Messages in this thread | | | Date | Mon, 13 Jan 2020 15:50:06 +0000 | From | Luis Chamberlain <> | Subject | Re: [PATCH v11 05/10] test_firmware: add support for firmware_request_platform |
| |
On Mon, Jan 13, 2020 at 04:22:36PM +0100, Hans de Goede wrote: > > test_firmware and dropping the mutex calls is better. I will make > this change for v12 of this series. > > I'll send out a v12 once the remarks from Andy Lutomirski's > have also been discussed.
Sure, just think twice about loosing the ability to access the test_firmware pointer from userspace. If you can find value in extending your tests then keep it, otherwise if its just to do the actual test in C in the call itself, it makes sense to avoid it for that test case.
Luis
| |