lkml.org 
[lkml]   [2020]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v11 05/10] test_firmware: add support for firmware_request_platform
On Mon, Jan 13, 2020 at 04:22:36PM +0100, Hans de Goede wrote:
>
> test_firmware and dropping the mutex calls is better. I will make
> this change for v12 of this series.
>
> I'll send out a v12 once the remarks from Andy Lutomirski's
> have also been discussed.

Sure, just think twice about loosing the ability to access the
test_firmware pointer from userspace. If you can find value
in extending your tests then keep it, otherwise if its just
to do the actual test in C in the call itself, it makes sense
to avoid it for that test case.

Luis

\
 
 \ /
  Last update: 2020-01-13 16:50    [W:0.665 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site