lkml.org 
[lkml]   [2020]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 6/8] media: adv748x: reduce amount of code for bitwise modification of device registers
    The regmap provides corresponding routine (regmap_update_bits) already
    wrapped for this device earlier.

    Signed-off-by: Alexander Riesen <alexander.riesen@cetitec.com>
    ---
    drivers/media/i2c/adv748x/adv748x.h | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/drivers/media/i2c/adv748x/adv748x.h b/drivers/media/i2c/adv748x/adv748x.h
    index 5db06410f102..ab3f754542fe 100644
    --- a/drivers/media/i2c/adv748x/adv748x.h
    +++ b/drivers/media/i2c/adv748x/adv748x.h
    @@ -432,7 +432,7 @@ int adv748x_update_bits(struct adv748x_state *state, u8 page, u8 reg,

    #define io_read(s, r) adv748x_read(s, ADV748X_PAGE_IO, r)
    #define io_write(s, r, v) adv748x_write(s, ADV748X_PAGE_IO, r, v)
    -#define io_clrset(s, r, m, v) io_write(s, r, (io_read(s, r) & ~m) | v)
    +#define io_clrset(s, r, m, v) adv748x_update_bits(s, ADV748X_PAGE_IO, r, m, v)
    #define io_update(s, r, m, v) adv748x_update_bits(s, ADV748X_PAGE_IO, r, m, v)

    #define hdmi_read(s, r) adv748x_read(s, ADV748X_PAGE_HDMI, r)
    @@ -450,11 +450,11 @@ int adv748x_update_bits(struct adv748x_state *state, u8 page, u8 reg,

    #define sdp_read(s, r) adv748x_read(s, ADV748X_PAGE_SDP, r)
    #define sdp_write(s, r, v) adv748x_write(s, ADV748X_PAGE_SDP, r, v)
    -#define sdp_clrset(s, r, m, v) sdp_write(s, r, (sdp_read(s, r) & ~m) | v)
    +#define sdp_clrset(s, r, m, v) adv748x_update_bits(s, ADV748X_PAGE_SDP, r, m, v)

    #define cp_read(s, r) adv748x_read(s, ADV748X_PAGE_CP, r)
    #define cp_write(s, r, v) adv748x_write(s, ADV748X_PAGE_CP, r, v)
    -#define cp_clrset(s, r, m, v) cp_write(s, r, (cp_read(s, r) & ~m) | v)
    +#define cp_clrset(s, r, m, v) adv748x_update_bits(s, ADV748X_PAGE_CP, r, m, v)

    #define tx_read(t, r) adv748x_read(t->state, t->page, r)
    #define tx_write(t, r, v) adv748x_write(t->state, t->page, r, v)
    --
    2.24.1.508.g91d2dafee0
    \
     
     \ /
      Last update: 2020-01-13 15:17    [W:4.077 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site