Messages in this thread | | | Subject | Re: [PATCH] xfs: Fix xfs_dir2_sf_entry_t size check | From | Vincenzo Frascino <> | Date | Mon, 13 Jan 2020 14:05:21 +0000 |
| |
Hi Arnd,
On 1/13/20 1:55 PM, Arnd Bergmann wrote: > On Thu, Jan 9, 2020 at 10:01 PM Vincenzo Frascino > <vincenzo.frascino@arm.com> wrote: >> >> Hi Darrick, >> >> On 09/01/2020 16:50, Darrick J. Wong wrote: >>> This sounds like gcc getting confused by the zero length array. Though >>> it's odd that randconfig breaks, but defconfig doesn't? This sounds >>> like one of the kernel gcc options causing problems. >>> >> >> This is what I started suspecting as well. > > The important bit into the configuration is > > # CONFIG_AEABI is not set > > With ARM OABI (which you get when EABI is disabled), structures are padded > to multiples of 32 bits. See commits 8353a649f577 ("xfs: kill > xfs_dir2_sf_off_t") > and aa2dd0ad4d6d ("xfs: remove __arch_pack"). Those could be partially > reverted to fix it again, but it doesn't seem worth it as there is > probably nobody > running XFS on OABI machines (actually with the build failure we can > be fairly sure there isn't ;-). >
Thanks for this, for some reasons I was convinced that CONFIG_AEABI was set in this configuration file as I reported as well in my previous email. Since it is OABI makes sense disabling xfs for randconfig purposes.
-- Regards, Vincenzo
| |