lkml.org 
[lkml]   [2020]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ata: pxa: Use dma_request_chan() instead dma_request_slave_channel()
From
Date

On 12/17/19 8:40 AM, Peter Ujfalusi wrote:
> dma_request_slave_channel() is a wrapper on top of dma_request_chan()
> eating up the error code.
>
> By using dma_request_chan() directly the driver can support deferred
> probing against DMA.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
> drivers/ata/pata_pxa.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/ata/pata_pxa.c b/drivers/ata/pata_pxa.c
> index 41430f79663c..71678bed04b0 100644
> --- a/drivers/ata/pata_pxa.c
> +++ b/drivers/ata/pata_pxa.c
> @@ -274,10 +274,9 @@ static int pxa_ata_probe(struct platform_device *pdev)
> /*
> * Request the DMA channel
> */
> - data->dma_chan =
> - dma_request_slave_channel(&pdev->dev, "data");
> - if (!data->dma_chan)
> - return -EBUSY;
> + data->dma_chan = dma_request_chan(&pdev->dev, "data");
> + if (IS_ERR(data->dma_chan))
> + return PTR_ERR(data->dma_chan);
> ret = dmaengine_slave_config(data->dma_chan, &config);
> if (ret < 0) {
> dev_err(&pdev->dev, "dma configuration failed: %d\n", ret);
>

\
 
 \ /
  Last update: 2020-01-13 12:23    [W:0.054 / U:6.880 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site