Messages in this thread | | | From | Chris Wilson <> | Subject | Re: [PATCH] drm/i915: convert to new logging macros based on struct intel_engine_cs. | Date | Mon, 13 Jan 2020 11:17:52 +0000 |
| |
Quoting Wambui Karuga (2020-01-13 11:10:25) > fn(...) { > ... > struct intel_engine_cs *E = ...; > +struct drm_i915_private *dev_priv = E->i915;
No new dev_priv.
There should be no reason for drm_dbg here, as the rest of the debug is behind ENGINE_TRACE and so the vestigial debug should be moved over, or deleted as not being useful.
The error messages look unhelpful.
> if ((batch_end - cmd) < length) { > - DRM_DEBUG("CMD: Command length exceeds batch length: 0x%08X length=%u batchlen=%td\n", > - *cmd, > - length, > - batch_end - cmd); > + drm_dbg(&dev_priv->drm, > + "CMD: Command length exceeds batch length: 0x%08X length=%u batchlen=%td\n",
No. This is not driver debug. If anything this should be pr_debug, or some over user centric channel. -Chris
| |