Messages in this thread | | | From | Radhey Shyam Pandey <> | Subject | RE: [PATCH 08/14] net: axienet: Drop MDIO interrupt registers from ethtools dump | Date | Mon, 13 Jan 2020 06:02:06 +0000 |
| |
> -----Original Message----- > From: Andre Przywara <andre.przywara@arm.com> > Sent: Friday, January 10, 2020 5:24 PM > To: David S . Miller <davem@davemloft.net>; Radhey Shyam Pandey > <radheys@xilinx.com> > Cc: Michal Simek <michals@xilinx.com>; Robert Hancock > <hancock@sedsystems.ca>; netdev@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-kernel@vger.kernel.org > Subject: [PATCH 08/14] net: axienet: Drop MDIO interrupt registers from > ethtools dump > > Newer revisions of the IP don't have these registers. Since we don't > really use them, just drop them from the ethtools dump. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > --- > drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c > b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c > index e83c7b005f50..7a747345e98e 100644 > --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c > +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c > @@ -1239,10 +1239,6 @@ static void axienet_ethtools_get_regs(struct > net_device *ndev, > data[20] = axienet_ior(lp, XAE_MDIO_MCR_OFFSET); > data[21] = axienet_ior(lp, XAE_MDIO_MWD_OFFSET); > data[22] = axienet_ior(lp, XAE_MDIO_MRD_OFFSET); > - data[23] = axienet_ior(lp, XAE_MDIO_MIS_OFFSET); > - data[24] = axienet_ior(lp, XAE_MDIO_MIP_OFFSET); > - data[25] = axienet_ior(lp, XAE_MDIO_MIE_OFFSET); > - data[26] = axienet_ior(lp, XAE_MDIO_MIC_OFFSET);
We can also remove these #defines from the header. Alternatively, we can cherry-pick commit f5b9e58 " net: xilinx: axiethernet: Fix axiethernet register description" from xilinx tree and include it in this series. > data[27] = axienet_ior(lp, XAE_UAW0_OFFSET); > data[28] = axienet_ior(lp, XAE_UAW1_OFFSET); > data[29] = axienet_ior(lp, XAE_FMI_OFFSET); > -- > 2.17.1
| |