lkml.org 
[lkml]   [2020]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next] net: phy: Maintain MDIO device and bus statistics
Hi Florian,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]
[also build test ERROR on net/master linus/master ipvs/master v5.5-rc6 next-20200110]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-phy-Maintain-MDIO-device-and-bus-statistics/20200113-125529
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 5c9166f038257d6130865b267cb45d87f126b3dd
config: x86_64-lkp (attached as .config)
compiler: gcc-7 (Debian 7.5.0-3) 7.5.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

drivers/net/phy/mdio_bus.c: In function 'mdio_bus_stats_transfers_show':
drivers/net/phy/mdio_bus.c:305:32: error: pasting ""%llu"" and ""\n"" does not give a valid preprocessing token
MDIO_BUS_STATS_SHOW(transfers, "%llu");
^
drivers/net/phy/mdio_bus.c:296:21: note: in definition of macro 'MDIO_BUS_STATS_SHOW_NAME'
len = sprintf(buf, format_string ## "\n", tmp); \
^~~~~~~~~~~~~
>> drivers/net/phy/mdio_bus.c:305:1: note: in expansion of macro 'MDIO_BUS_STATS_SHOW'
MDIO_BUS_STATS_SHOW(transfers, "%llu");
^~~~~~~~~~~~~~~~~~~
drivers/net/phy/mdio_bus.c: In function 'mdio_bus_stats_errors_show':
drivers/net/phy/mdio_bus.c:306:29: error: pasting ""%llu"" and ""\n"" does not give a valid preprocessing token
MDIO_BUS_STATS_SHOW(errors, "%llu");
^
drivers/net/phy/mdio_bus.c:296:21: note: in definition of macro 'MDIO_BUS_STATS_SHOW_NAME'
len = sprintf(buf, format_string ## "\n", tmp); \
^~~~~~~~~~~~~
drivers/net/phy/mdio_bus.c:306:1: note: in expansion of macro 'MDIO_BUS_STATS_SHOW'
MDIO_BUS_STATS_SHOW(errors, "%llu");
^~~~~~~~~~~~~~~~~~~
drivers/net/phy/mdio_bus.c: In function 'mdio_bus_stats_writes_show':
drivers/net/phy/mdio_bus.c:307:29: error: pasting ""%llu"" and ""\n"" does not give a valid preprocessing token
MDIO_BUS_STATS_SHOW(writes, "%llu");
^
drivers/net/phy/mdio_bus.c:296:21: note: in definition of macro 'MDIO_BUS_STATS_SHOW_NAME'
len = sprintf(buf, format_string ## "\n", tmp); \
^~~~~~~~~~~~~
drivers/net/phy/mdio_bus.c:307:1: note: in expansion of macro 'MDIO_BUS_STATS_SHOW'
MDIO_BUS_STATS_SHOW(writes, "%llu");
^~~~~~~~~~~~~~~~~~~
drivers/net/phy/mdio_bus.c: In function 'mdio_bus_stats_reads_show':
drivers/net/phy/mdio_bus.c:308:28: error: pasting ""%llu"" and ""\n"" does not give a valid preprocessing token
MDIO_BUS_STATS_SHOW(reads, "%llu");
^
drivers/net/phy/mdio_bus.c:296:21: note: in definition of macro 'MDIO_BUS_STATS_SHOW_NAME'
len = sprintf(buf, format_string ## "\n", tmp); \
^~~~~~~~~~~~~
drivers/net/phy/mdio_bus.c:308:1: note: in expansion of macro 'MDIO_BUS_STATS_SHOW'
MDIO_BUS_STATS_SHOW(reads, "%llu");
^~~~~~~~~~~~~~~~~~~

vim +305 drivers/net/phy/mdio_bus.c

300
301 #define MDIO_BUS_STATS_SHOW(field, format_string) \
302 MDIO_BUS_STATS_SHOW_NAME(field, __stringify(field), \
303 field, format_string)
304
> 305 MDIO_BUS_STATS_SHOW(transfers, "%llu");
306 MDIO_BUS_STATS_SHOW(errors, "%llu");
307 MDIO_BUS_STATS_SHOW(writes, "%llu");
308 MDIO_BUS_STATS_SHOW(reads, "%llu");
309

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2020-01-14 05:46    [W:0.067 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site