lkml.org 
[lkml]   [2020]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 4/8] i2c: tegra: Support atomic transfers
From
Date
14.01.2020 01:03, Wolfram Sang пишет:
> On Sun, Jan 12, 2020 at 08:14:26PM +0300, Dmitry Osipenko wrote:
>> System shutdown may happen with interrupts being disabled and in this case
>> I2C core rejects transfers if atomic transfer isn't supported by driver.
>
> Well, not quite. The core complains about it nowadays, but does not
> reject messages. It will try the same behaviour as before. It will just
> inform the user that somethings is tried which may not work. I probably
> should update the error message printed saying that the transfer is
> still tried.

Indeed, now I'm recalling noticing that the transfer actually should
happen despite of the error message, but then completely forgot to
update the commit's message. I can update the message and send out v5,
if you're thinking that it's worthwhile to do.

>> There were several occurrences where I found my Nexus 7 completely
>> discharged despite of being turned off and then one day I spotted this in
>> the log:
>
> Given my reasoning above, that should have happened before the warning
> was printed as well? Because same behaviour. I'd be surprised if there
> was a change...

Pretty sure that it was happening before, but I wasn't paying much
attention back then.

\
 
 \ /
  Last update: 2020-01-13 23:53    [W:0.040 / U:28.856 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site