lkml.org 
[lkml]   [2020]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V4 1/5] dt-bindings: pinctrl: qcom: Add ipq6018 pinctrl bindings
    On Thu, Jan 09, 2020 at 02:48:59PM +0530, Sricharan R wrote:
    > Add device tree binding Documentation details for ipq6018
    > pinctrl driver.
    >
    > Co-developed-by: Rajkumar Ayyasamy <arajkuma@codeaurora.org>
    > Signed-off-by: Rajkumar Ayyasamy <arajkuma@codeaurora.org>
    > Co-developed-by: Selvam Sathappan Periakaruppan <speriaka@codeaurora.org>
    > Signed-off-by: Selvam Sathappan Periakaruppan <speriaka@codeaurora.org>
    > Co-developed-by: Sivaprakash Murugesan <sivaprak@codeaurora.org>
    > Signed-off-by: Sivaprakash Murugesan <sivaprak@codeaurora.org>
    > Signed-off-by: Sricharan R <sricharan@codeaurora.org>
    > ---
    > [V4]
    > * cleaned-up schema as per Rob's comments.
    > * Ran make dt_binding_check and no issues.
    >
    > .../bindings/pinctrl/qcom,ipq6018-pinctrl.yaml | 140 +++++++++++++++++++++
    > 1 file changed, 140 insertions(+)
    > create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml
    >
    > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml
    > new file mode 100644
    > index 0000000..68c3c8c
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml
    > @@ -0,0 +1,140 @@
    > +# SPDX-License-Identifier: GPL-2.0-or-later

    Dual license please.

    (GPL-2.0-only or BSD-2-Clause)

    > +%YAML 1.2
    > +---
    > +$id: http://devicetree.org/schemas/pinctrl/qcom,ipq6018-pinctrl.yaml#
    > +$schema: http://devicetree.org/meta-schemas/core.yaml#
    > +
    > +title: Qualcomm Technologies, Inc. IPQ6018 TLMM block
    > +
    > +maintainers:
    > + - Sricharan R <sricharan@codeaurora.org>
    > +
    > +description: |
    > + This binding describes the Top Level Mode Multiplexer block found in the
    > + IPQ6018 platform.
    > +
    > +properties:
    > + compatible:
    > + const: qcom,ipq6018-pinctrl
    > +
    > + reg:
    > + maxItems: 1
    > +
    > + interrupts:
    > + description: Specifies the TLMM summary IRQ
    > + maxItems: 1
    > +
    > + interrupt-controller: true
    > +
    > + '#interrupt-cells':
    > + description:
    > + Specifies the PIN numbers and Flags, as defined in defined in
    > + include/dt-bindings/interrupt-controller/irq.h
    > + const: 2
    > +
    > + gpio-controller: true
    > +
    > + '#gpio-cells':
    > + description: Specifying the pin number and flags, as defined in
    > + include/dt-bindings/gpio/gpio.h
    > + const: 2
    > +
    > + gpio-ranges:
    > + description: Documentation/devicetree/bindings/gpio/gpio.txt
    > + maxItems: 1
    > +
    > +#PIN CONFIGURATION NODES
    > +patternProperties:
    > + '-pins$':
    > + type: object
    > + description:
    > + Pinctrl node's client devices use subnodes for desired pin configuration.
    > + Client device subnodes use below standard properties.
    > + allOf:
    > + - $ref: "/schemas/pinctrl/pincfg-node.yaml"
    > +
    > + properties:
    > + pins:
    > + description:
    > + List of gpio pins affected by the properties specified in this
    > + subnode.
    > + allOf:
    > + - $ref: "/schemas/types.yaml#/definitions/string"

    No need for type ref as the common binding does this.

    > + - enum: ['gpio$', sdc1_clk, sdc1_cmd, sdc1_data, sdc2_clk, sdc2_cmd,
    > + sdc2_data, qdsd_cmd, qdsd_data0, qdsd_data1, qdsd_data2,
    > + qdsd_data3]
    > +
    > + function:
    > + description:
    > + Specify the alternative function to be configured for the specified
    > + pins.
    > + allOf:
    > + - $ref: "/schemas/types.yaml#/definitions/string"

    Same here.

    > + - enum: [ adsp_ext, alsp_int, atest_bbrx0, atest_bbrx1, atest_char,
    > + atest_char0, atest_char1, atest_char2, atest_char3, atest_combodac,
    > + atest_gpsadc0, atest_gpsadc1, atest_tsens, atest_wlan0,
    > + atest_wlan1, backlight_en, bimc_dte0, bimc_dte1, blsp_i2c1,
    > + blsp_i2c2, blsp_i2c3, blsp_i2c4, blsp_i2c5, blsp_i2c6, blsp_spi1,
    > + blsp_spi1_cs1, blsp_spi1_cs2, blsp_spi1_cs3, blsp_spi2,
    > + blsp_spi2_cs1, blsp_spi2_cs2, blsp_spi2_cs3, blsp_spi3,
    > + blsp_spi3_cs1, blsp_spi3_cs2, blsp_spi3_cs3, blsp_spi4, blsp_spi5,
    > + blsp_spi6, blsp_uart1, blsp_uart2, blsp_uim1, blsp_uim2, cam1_rst,
    > + cam1_standby, cam_mclk0, cam_mclk1, cci_async, cci_i2c, cci_timer0,
    > + cci_timer1, cci_timer2, cdc_pdm0, codec_mad, dbg_out, display_5v,
    > + dmic0_clk, dmic0_data, dsi_rst, ebi0_wrcdc, euro_us, ext_lpass,
    > + flash_strobe, gcc_gp1_clk_a, gcc_gp1_clk_b, gcc_gp2_clk_a,
    > + gcc_gp2_clk_b, gcc_gp3_clk_a, gcc_gp3_clk_b, gpio, gsm0_tx0,
    > + gsm0_tx1, gsm1_tx0, gsm1_tx1, gyro_accl, kpsns0, kpsns1, kpsns2,
    > + ldo_en, ldo_update, mag_int, mdp_vsync, modem_tsync, m_voc,
    > + nav_pps, nav_tsync, pa_indicator, pbs0, pbs1, pbs2, pri_mi2s,
    > + pri_mi2s_ws, prng_rosc, pwr_crypto_enabled_a, pwr_crypto_enabled_b,
    > + pwr_modem_enabled_a, pwr_modem_enabled_b, pwr_nav_enabled_a,
    > + pwr_nav_enabled_b, qdss_ctitrig_in_a0, qdss_ctitrig_in_a1,
    > + qdss_ctitrig_in_b0, qdss_ctitrig_in_b1, qdss_ctitrig_out_a0,
    > + qdss_ctitrig_out_a1, qdss_ctitrig_out_b0, qdss_ctitrig_out_b1,
    > + qdss_traceclk_a, qdss_traceclk_b, qdss_tracectl_a, qdss_tracectl_b,
    > + qdss_tracedata_a, qdss_tracedata_b, reset_n, sd_card, sd_write,
    > + sec_mi2s, smb_int, ssbi_wtr0, ssbi_wtr1, uim1, uim2, uim3,
    > + uim_batt, wcss_bt, wcss_fm, wcss_wlan, webcam1_rst ]
    > +
    > + drive-strength:
    > + allOf:
    > + - $ref: "/schemas/types.yaml#/definitions/uint32"

    Same here.

    > + - enum: [2, 4, 6, 8, 10, 12, 14, 16]

    default?

    > + description:
    > + Selects the drive strength for the specified pins, in mA.

    > +
    > + required:
    > + - pins
    > + - function

    additionalProperties: false

    You'll need to list any other properties you use. Based
    on the example, you'll need 'bias-pull-down: true'.

    > +
    > +required:
    > + - compatible
    > + - reg
    > + - interrupts
    > + - interrupt-controller
    > + - '#interrupt-cells'
    > + - gpio-controller
    > + - '#gpio-cells'
    > + - gpio-ranges

    additionalProperties: false

    > +
    > +examples:
    > + - |
    > + #include <dt-bindings/interrupt-controller/arm-gic.h>
    > + tlmm: pinctrl@1000000 {
    > + compatible = "qcom,ipq6018-pinctrl";
    > + reg = <0x01000000 0x300000>;
    > + interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
    > + gpio-controller;
    > + #gpio-cells = <2>;
    > + gpio-ranges = <&tlmm 0 80>;
    > + interrupt-controller;
    > + #interrupt-cells = <2>;
    > +
    > + serial3-pinmux {

    Doesn't match the schema.

    > + pins = "gpio44", "gpio45";
    > + function = "blsp2_uart";
    > + drive-strength = <8>;
    > + bias-pull-down;
    > + };
    > + };
    > --
    > 2.7.4
    >

    \
     
     \ /
      Last update: 2020-01-13 23:50    [W:3.194 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site