lkml.org 
[lkml]   [2020]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V11 1/5] mm/hotplug: Introduce arch callback validating the hot remove range
From
Date


On 01/11/2020 07:41 PM, kbuild test robot wrote:
> mm/memory_hotplug.c: In function 'check_hotremove_memory_range':
>>> mm/memory_hotplug.c:1027:7: error: implicit declaration of function 'arch_memory_removable'; did you mean 'add_memory_resource'? [-Werror=implicit-function-declaration]
> rc = arch_memory_removable(start, size);
> ^~~~~~~~~~~~~~~~~~~~~
> add_memory_resource
> At top level:
> mm/memory_hotplug.c:1017:12: warning: 'check_hotremove_memory_range' defined but not used [-Wunused-function]
> static int check_hotremove_memory_range(u64 start, u64 size)
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
>
> vim +1027 mm/memory_hotplug.c
>
> 1016
> 1017 static int check_hotremove_memory_range(u64 start, u64 size)
> 1018 {
> 1019 int rc;
> 1020
> 1021 BUG_ON(check_hotplug_memory_range(start, size));
> 1022
> 1023 /*
> 1024 * First check if the platform is willing to have this
> 1025 * memory range removed else just abort.
> 1026 */
>> 1027 rc = arch_memory_removable(start, size);
> 1028 if (!rc)
> 1029 return -EINVAL;
> 1030
> 1031 return 0;
> 1032 }
> 1033


Both the build failures reported here could be solved by moving
check_hotremove_memory_range() inside CONFIG_MEMORY_HOTREMOVE
wrappers, will fix it.

- Anshuman

\
 
 \ /
  Last update: 2020-01-13 05:05    [W:0.115 / U:9.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site