Messages in this thread | | | From | Daniel Drake <> | Date | Mon, 13 Jan 2020 11:47:25 +0800 | Subject | Re: [PATCH] platform/x86: asus-wmi: Fix keyboard brightness cannot be set to 0 |
| |
On Tue, Dec 31, 2019 at 2:53 PM Daniel Drake <drake@endlessm.com> wrote: > Here, writing 0x80 to turn off the keyboard LED will result in an > additional WRAM(0x9f0, 0) call that was not there before. I think we > should double check this detail. > > Let's see if we can borrow one of the affected models and double check > this patch there before proceeding. I'll follow up internally.
Asus were unable to find a product sample with the affected behaviour. They did provide us with one from the list I had made, but with a newer BIOS version where that behaviour has been eliminated. They also advised that always setting bit 7 is the way they do it on Windows. So I don't think we have the opportunity for extra verification, but it should be safe.
Reviewed-by: Daniel Drake <drake@endlessm.com>
| |