lkml.org 
[lkml]   [2020]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 032/165] netfilter: nf_tables_offload: return EOPNOTSUPP if rule specifies no actions
    Date
    From: Pablo Neira Ayuso <pablo@netfilter.org>

    [ Upstream commit 81ec61074bcf68acfcb2820cda3ff9d9984419c7 ]

    If the rule only specifies the matching side, return EOPNOTSUPP.
    Otherwise, the front-end relies on the drivers to reject this rule.

    Fixes: c9626a2cbdb2 ("netfilter: nf_tables: add hardware offload support")
    Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/netfilter/nf_tables_offload.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/net/netfilter/nf_tables_offload.c b/net/netfilter/nf_tables_offload.c
    index 6f7eab502e65..e743f811245f 100644
    --- a/net/netfilter/nf_tables_offload.c
    +++ b/net/netfilter/nf_tables_offload.c
    @@ -44,6 +44,9 @@ struct nft_flow_rule *nft_flow_rule_create(struct net *net,
    expr = nft_expr_next(expr);
    }

    + if (num_actions == 0)
    + return ERR_PTR(-EOPNOTSUPP);
    +
    flow = nft_flow_rule_alloc(num_actions);
    if (!flow)
    return ERR_PTR(-ENOMEM);
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-11 11:23    [W:4.102 / U:1.444 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site