lkml.org 
[lkml]   [2020]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 15/62] spi: spi-cavium-thunderx: Add missing pci_release_regions()
    Date
    From: Chuhong Yuan <hslester96@gmail.com>

    [ Upstream commit a841e2853e1afecc2ee692b8cc5bff606bc84e4c ]

    The driver forgets to call pci_release_regions() in probe failure
    and remove.
    Add the missed calls to fix it.

    Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
    Link: https://lore.kernel.org/r/20191206075500.18525-1-hslester96@gmail.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/spi/spi-cavium-thunderx.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/spi/spi-cavium-thunderx.c b/drivers/spi/spi-cavium-thunderx.c
    index 877937706240..828fbbebc3c4 100644
    --- a/drivers/spi/spi-cavium-thunderx.c
    +++ b/drivers/spi/spi-cavium-thunderx.c
    @@ -81,6 +81,7 @@ static int thunderx_spi_probe(struct pci_dev *pdev,

    error:
    clk_disable_unprepare(p->clk);
    + pci_release_regions(pdev);
    spi_master_put(master);
    return ret;
    }
    @@ -95,6 +96,7 @@ static void thunderx_spi_remove(struct pci_dev *pdev)
    return;

    clk_disable_unprepare(p->clk);
    + pci_release_regions(pdev);
    /* Put everything in a known state. */
    writeq(0, p->register_base + OCTEON_SPI_CFG(p));
    }
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-11 11:10    [W:4.209 / U:0.360 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site