Messages in this thread | | | Subject | Re: [PATCH kunit] kunit: building kunit as a module breaks allmodconfig | From | Shuah Khan <> | Date | Fri, 10 Jan 2020 14:39:10 -0700 |
| |
Hi Alan,
On 1/10/20 4:49 AM, Alan Maguire wrote: > kunit tests that do not support module build should depend > on KUNIT=y rather than just KUNIT in Kconfig, otherwise > they will trigger compilation errors for "make allmodconfig" > builds. > > Fixes: 9fe124bf1b77 ("kunit: allow kunit to be loaded as a module") > Signed-off-by: Alan Maguire <alan.maguire@oracle.com> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Thanks for fixing this quickly. For future reference, Signed-off-by should be last. I fixed it and applied the patch.
thanks, -- Shuah
| |