Messages in this thread | | | Date | Fri, 10 Jan 2020 13:34:41 +0100 (CET) | From | Julia Lawall <> | Subject | Re: [PATCH v2] coccinelle: semantic patch to check for inappropriate do_div() calls |
| |
On Fri, 10 Jan 2020, Markus Elfring wrote:
> > +@initialize:python@ > … > > +def construct_warnings(str, suggested_fun): > > This function will be used only for the operation modes “org” and “report”. > Thus I suggest to replace the specification “initialize” by a corresponding dependency > which is already applied for the SmPL rule “r”. > > > Can subsequent SmPL disjunctions become more succinct? > > > The passing of function name variants contains a bit of duplicate Python code. > Will a feature request like “Support for SmPL rule groups” become more interesting > for the shown use case? > https://github.com/coccinelle/coccinelle/issues/164
The code is fine as it is in these respects.
julia
| |