lkml.org 
[lkml]   [2020]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v1] mfd: syscon: Switch to use devm_ioremap_resource()
On Fri, Jan 10, 2020 at 12:40 PM Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Fri, Jan 10, 2020 at 11:15 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > Instead of checking resource pointer for being NULL and
> > report some not very standard error codes in this case,
> > switch to devm_ioremap_resource() API.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> With syscon, I'm worried there are users that map the same region in another
> driver, so doing devm_ioremap_resource() here will make another driver fail.
>
> Maybe just change the error code and add a comment warning about that
> instead?

Oh, yes, you are right.

Thanks for review.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2020-01-10 13:03    [W:0.038 / U:5.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site