| Date | Fri, 10 Jan 2020 12:00:33 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH 4.19 118/219] rfkill: allocate static minor |
| |
On Sun 2019-12-29 18:18:40, Greg Kroah-Hartman wrote: > From: Marcel Holtmann <marcel@holtmann.org> > > [ Upstream commit 8670b2b8b029a6650d133486be9d2ace146fd29a ] > > udev has a feature of creating /dev/<node> device-nodes if it finds > a devnode:<node> modalias. This allows for auto-loading of modules that > provide the node. This requires to use a statically allocated minor > number for misc character devices. > > However, rfkill uses dynamic minor numbers and prevents auto-loading > of the module. So allocate the next static misc minor number and use > it for rfkill.
Is this good idea for stable?
I don't see this major/minor allocated in devices.txt in mainline. Should something like this be added?
Signed-off-by: Pavel Machek <pavel@denx.de>
diff --git a/Documentation/admin-guide/devices.txt b/Documentation/admin-guide/devices.txt index 1c5d2281efc9..aa888a350df8 100644 --- a/Documentation/admin-guide/devices.txt +++ b/Documentation/admin-guide/devices.txt @@ -375,8 +375,9 @@ 239 = /dev/uhid User-space I/O driver support for HID subsystem 240 = /dev/userio Serio driver testing device 241 = /dev/vhost-vsock Host kernel driver for virtio vsock + 242 = /dev/rfkill Turning off radio transmissions (rfkill) - 242-254 Reserved for local use + 243-254 Reserved for local use 255 Reserved for MISC_DYNAMIC_MINOR 11 char Raw keyboard device (Linux/SPARC only)
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] |