Messages in this thread | | | Subject | Re: [PATCH] efi: Fix comment for efi_mem_type() wrt absent physical addresses | From | Anshuman Khandual <> | Date | Fri, 10 Jan 2020 11:42:24 +0530 |
| |
On 11/11/2019 10:43 AM, Anshuman Khandual wrote: > A previous commit f99afd08a45f ("efi: Update efi_mem_type() to return an > error rather than 0") changed the return type from EFI_RESERVED_TYPE to > -EINVAL when the searched physical address is not present in any memory > descriptor. But the comment preceding the function never changed. Lets > change the comment now to reflect the new return type -EINVAL. > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > Cc: linux-efi@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
Hello Ard,
Just wondering if this patch is getting pulled. Dont see it either on linux-next or the following EFI tree.
git://git.kernel.org/pub/scm/linux/kernel/git/efi/efi (efi-next)
- Anshuman
> --- > Changes in V2: > > - Changed comment for efi_mem_type() instead of the return type per Ard > > V1: (https://lore.kernel.org/patchwork/patch/1149002/) > > drivers/firmware/efi/efi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c > index 77ca52d86e30..47b0bf7a2b7f 100644 > --- a/drivers/firmware/efi/efi.c > +++ b/drivers/firmware/efi/efi.c > @@ -899,7 +899,7 @@ u64 efi_mem_attributes(unsigned long phys_addr) > * > * Search in the EFI memory map for the region covering @phys_addr. > * Returns the EFI memory type if the region was found in the memory > - * map, EFI_RESERVED_TYPE (zero) otherwise. > + * map, -EINVAL otherwise. > */ > int efi_mem_type(unsigned long phys_addr) > { >
| |