lkml.org 
[lkml]   [2020]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 1/2] amr64: dts: modify mt8183.dtsi
From
Date


On 08/01/2020 10:14, Nicolas Boichat wrote:
> On Wed, Jan 8, 2020 at 4:56 PM Nicolas Boichat <drinkcat@chromium.org> wrote:
>>
>> minor nit, s/amr64/arm64/ in the commit title.
>>
>> On Fri, Dec 27, 2019 at 10:15 PM Yong Liang <yong.liang@mediatek.com> wrote:
>>>
>>> From: "yong.liang" <yong.liang@mediatek.com>
>>>
>>> 1. Include mt8183-reset.h and add reset-cells in infracfg
>>> in dtsi file
>
> Err, wait, doesn't this depend on
> http://lists.infradead.org/pipermail/linux-mediatek/2020-January/026170.html
> ?
>

That's all a bit confusing, I thought we are fine to add the reset cells to
infracfg as we have the resets defined in
64ebb57a3df6 ("clk: reset: Modify reset-controller driver")

That's why I took this part from:
https://lore.kernel.org/linux-mediatek/20191226093930.22413-1-yong.liang@mediatek.com/

Please let me know if I'm wrong and I'll drop it.

Regards,
Matthias

>>> 2. Add watchdog device node
>
> Can we have a patch with just this change instead, since you're
> sending the binding with it.
>
>>>
>>> Signed-off-by: yong.liang <yong.liang@mediatek.com>
>>
>> Tested-by: Nicolas Boichat <drinkcat@chromium.org>
>>
>>> ---
>>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 8 ++++++++
>>> 1 file changed, 8 insertions(+)
>>> [snip]

\
 
 \ /
  Last update: 2020-01-10 11:11    [W:0.066 / U:20.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site