lkml.org 
[lkml]   [2020]   [Jan]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 08/10] MIPS: use resource_size
    On Wed, Jan 1, 2020 at 7:26 PM Julia Lawall <Julia.Lawall@inria.fr> wrote:
    >
    > Use resource_size rather than a verbose computation on
    > the end and start fields.
    >
    > The semantic patch that makes these changes is as follows:
    > (http://coccinelle.lip6.fr/)
    >
    > <smpl>
    > @@ struct resource ptr; @@
    > - (ptr.end - ptr.start + 1)
    > + resource_size(&ptr)
    > </smpl>
    >
    > Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
    >
    > ---
    > arch/mips/kernel/setup.c | 6 ++----
    > 1 file changed, 2 insertions(+), 4 deletions(-)
    >
    > diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
    > index c3d4212b5f1d..701f4bc3046f 100644
    > --- a/arch/mips/kernel/setup.c
    > +++ b/arch/mips/kernel/setup.c
    > @@ -515,8 +515,7 @@ static void __init request_crashkernel(struct resource *res)
    > ret = request_resource(res, &crashk_res);
    > if (!ret)
    > pr_info("Reserving %ldMB of memory at %ldMB for crashkernel\n",
    > - (unsigned long)((crashk_res.end -
    > - crashk_res.start + 1) >> 20),
    > + (unsigned long)(resource_size(&crashk_res) >> 20),
    > (unsigned long)(crashk_res.start >> 20));
    > }
    > #else /* !defined(CONFIG_KEXEC) */
    > @@ -698,8 +697,7 @@ static void __init arch_mem_init(char **cmdline_p)
    > mips_parse_crashkernel();
    > #ifdef CONFIG_KEXEC
    > if (crashk_res.start != crashk_res.end)
    > - memblock_reserve(crashk_res.start,
    > - crashk_res.end - crashk_res.start + 1);
    > + memblock_reserve(crashk_res.start, resource_size(&crashk_res));
    > #endif
    > device_tree_init();
    > sparse_init();
    >

    Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

    Thanks Julia!

    \
     
     \ /
      Last update: 2020-01-01 23:21    [W:6.005 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site