lkml.org 
[lkml]   [2019]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/2] module: move CONFIG_UNUSED_SYMBOLS to the sub-menu of MODULES
    Date
    When CONFIG_MODULES is disabled, CONFIG_UNUSED_SYMBOLS is pointless,
    thus it should be invisible.

    Instead of adding "depends on MODULES", I moved it to the sub-menu
    "Enable loadable module support", which is a better fit. I put it
    close to TRIM_UNUSED_KSYMS because it depends on !UNUSED_SYMBOLS.

    Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
    ---

    init/Kconfig | 16 ++++++++++++++++
    lib/Kconfig.debug | 16 ----------------
    2 files changed, 16 insertions(+), 16 deletions(-)

    diff --git a/init/Kconfig b/init/Kconfig
    index 9e72cc6071f5..b3100aa3138f 100644
    --- a/init/Kconfig
    +++ b/init/Kconfig
    @@ -2117,6 +2117,22 @@ config MODULE_COMPRESS_XZ

    endchoice

    +config UNUSED_SYMBOLS
    + bool "Enable unused/obsolete exported symbols"
    + default y if X86
    + help
    + Unused but exported symbols make the kernel needlessly bigger. For
    + that reason most of these unused exports will soon be removed. This
    + option is provided temporarily to provide a transition period in case
    + some external kernel module needs one of these symbols anyway. If you
    + encounter such a case in your module, consider if you are actually
    + using the right API. (rationale: since nobody in the kernel is using
    + this in a module, there is a pretty good chance it's actually the
    + wrong interface to use). If you really need the symbol, please send a
    + mail to the linux kernel mailing list mentioning the symbol and why
    + you really need it, and what the merge plan to the mainline kernel for
    + your module is.
    +
    config TRIM_UNUSED_KSYMS
    bool "Trim unused exported kernel symbols"
    depends on !UNUSED_SYMBOLS
    diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
    index 5960e2980a8a..e0e14780a13d 100644
    --- a/lib/Kconfig.debug
    +++ b/lib/Kconfig.debug
    @@ -277,22 +277,6 @@ config READABLE_ASM
    to keep kernel developers who have to stare a lot at assembler listings
    sane.

    -config UNUSED_SYMBOLS
    - bool "Enable unused/obsolete exported symbols"
    - default y if X86
    - help
    - Unused but exported symbols make the kernel needlessly bigger. For
    - that reason most of these unused exports will soon be removed. This
    - option is provided temporarily to provide a transition period in case
    - some external kernel module needs one of these symbols anyway. If you
    - encounter such a case in your module, consider if you are actually
    - using the right API. (rationale: since nobody in the kernel is using
    - this in a module, there is a pretty good chance it's actually the
    - wrong interface to use). If you really need the symbol, please send a
    - mail to the linux kernel mailing list mentioning the symbol and why
    - you really need it, and what the merge plan to the mainline kernel for
    - your module is.
    -
    config DEBUG_FS
    bool "Debug Filesystem"
    help
    --
    2.17.1
    \
     
     \ /
      Last update: 2019-09-09 13:04    [W:3.634 / U:0.320 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site