lkml.org 
[lkml]   [2019]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] iio: accel: adxl372: Make sure interrupts are disabled
On Tue, 3 Sep 2019 12:19:11 +0300
Stefan Popa <stefan.popa@analog.com> wrote:

> This patch disables the adxl372 interrupts at setup. The interrupts
> should be enabled together with the iio buffer. Not doing this, might
> cause an unwanted interrupt to trigger without being able to properly
> clear it.
>
> Signed-off-by: Stefan Popa <stefan.popa@analog.com>

Given the device has a software reset, would we be better off
just hitting that to make sure we are in a consistent state after
driver start up?

Thanks,

Jonathan


> ---
> drivers/iio/accel/adxl372.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/iio/accel/adxl372.c b/drivers/iio/accel/adxl372.c
> index 72d3f45..77651f4 100644
> --- a/drivers/iio/accel/adxl372.c
> +++ b/drivers/iio/accel/adxl372.c
> @@ -609,6 +609,10 @@ static int adxl372_setup(struct adxl372_state *st)
> if (ret < 0)
> return ret;
>
> + ret = adxl372_set_interrupts(st, 0, 0);
> + if (ret < 0)
> + return ret;
> +
> /* Set the mode of operation to full bandwidth measurement mode */
> return adxl372_set_op_mode(st, ADXL372_FULL_BW_MEASUREMENT);
> }

\
 
 \ /
  Last update: 2019-09-08 11:32    [W:0.246 / U:0.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site