lkml.org 
[lkml]   [2019]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 28/57] liquidio: add cleanup in octeon_setup_iq()
    Date
    [ Upstream commit 6f967f8b1be7001b31c46429f2ee7d275af2190f ]

    If oct->fn_list.enable_io_queues() fails, no cleanup is executed, leading
    to memory/resource leaks. To fix this issue, invoke
    octeon_delete_instr_queue() before returning from the function.

    Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/cavium/liquidio/request_manager.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/cavium/liquidio/request_manager.c b/drivers/net/ethernet/cavium/liquidio/request_manager.c
    index 8f746e1348d4c..3deb3c07681fd 100644
    --- a/drivers/net/ethernet/cavium/liquidio/request_manager.c
    +++ b/drivers/net/ethernet/cavium/liquidio/request_manager.c
    @@ -238,8 +238,10 @@ int octeon_setup_iq(struct octeon_device *oct,
    }

    oct->num_iqs++;
    - if (oct->fn_list.enable_io_queues(oct))
    + if (oct->fn_list.enable_io_queues(oct)) {
    + octeon_delete_instr_queue(oct, iq_no);
    return 1;
    + }

    return 0;
    }
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-09-08 14:58    [W:3.555 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site