lkml.org 
[lkml]   [2019]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] rdma/siw: fix NOMMU build
    On Sat, Sep 7, 2019 at 9:34 AM Jason Gunthorpe <jgg@mellanox.com> wrote:
    > > @@ -374,7 +374,7 @@ struct siw_umem *siw_umem_get(u64 start, u64 len, bool writable)
    > > unsigned int foll_flags = FOLL_WRITE;
    > > int num_pages, num_chunks, i, rv = 0;
    > >
    > > - if (!can_do_mlock())
    > > + if (!IS_ENABLED(CONFIG_MMU) || !can_do_mlock())
    > > return ERR_PTR(-EPERM);
    >
    > I feel like !CONFIG_MMU should provide a dummy inline stub for can_do_mlock
    > instead?

    Fair enough. I've added that to my test tree in place of my first patch
    and will send it after some more build testing.

    Arnd

    \
     
     \ /
      Last update: 2019-09-07 14:58    [W:5.386 / U:0.308 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site