lkml.org 
[lkml]   [2019]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH AUTOSEL 4.19 126/167] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations
From
Date
On Tue, 2019-09-03 at 09:39 -0700, Doug Anderson wrote:
> Hi,
>
> On Tue, Sep 3, 2019 at 9:28 AM Sasha Levin <sashal@kernel.org> wrote:
> > From: Vadim Sukhomlinov <sukhomlinov@google.com>
> >
> > [ Upstream commit db4d8cb9c9f2af71c4d087817160d866ed572cc9 ]
> >
> > TPM 2.0 Shutdown involve sending TPM2_Shutdown to TPM chip and disabling
> > future TPM operations. TPM 1.2 behavior was different, future TPM
> > operations weren't disabled, causing rare issues. This patch ensures
> > that future TPM operations are disabled.
> >
> > Fixes: d1bd4a792d39 ("tpm: Issue a TPM2_Shutdown for TPM2 devices.")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Vadim Sukhomlinov <sukhomlinov@google.com>
> > [dianders: resolved merge conflicts with mainline]
> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
> > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > Signed-off-by: Sasha Levin <sashal@kernel.org>
> > ---
> > drivers/char/tpm/tpm-chip.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
>
> Jarkko: did you deal with the issues that came up in response to my
> post? Are you happy with this going into 4.19 stable at this point?
> I notice this has your Signed-off-by so maybe?

No I have not dealt with the issues yet. The last thing I've said about
this is:

https://lore.kernel.org/stable/20190805210501.vjtmwgxjg334vtnc@linux.intel.com/

I was actually going to look into this during the plane trip to Lissabon
tomorrow morning. I have in mind that this needs to be backported first:

db4d8cb9c9f2 ("tpm: use tpm_try_get_ops() in tpm-sysfs.c.")

/Jarkko

\
 
 \ /
  Last update: 2019-09-07 18:56    [W:0.117 / U:5.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site