Messages in this thread | | | From | Arnd Bergmann <> | Date | Fri, 6 Sep 2019 20:52:26 +0200 | Subject | Re: [PATCH] pinctrl: intel: hide unused intel_pin_to_gpio |
| |
On Fri, Sep 6, 2019 at 6:59 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Fri, Sep 06, 2019 at 05:26:01PM +0200, Arnd Bergmann wrote: > > The intel_pin_to_gpio() function is only called by the > > PM support functions and causes a warning when those are disabled: > > > > drivers/pinctrl/intel/pinctrl-intel.c:841:12: error: unused function 'intel_pin_to_gpio' [-Werror,-Wunused-function] > > > > As we cannot change the PM functions themselves to use __maybe_unused, > > add another #ifdef here for consistency. > > It's not adding another #ifdef here... > > Nevertheless, I'm afraid that in the future we might need this in other > place(s). Can we add __maybe_unused to this function exclusively?
Ok, sending v2 now.
Arnd
| |