Messages in this thread | | | Subject | Re: [Xen-devel] [PATCH] ARM: xen: unexport HYPERVISOR_platform_op function | From | Andrew Cooper <> | Date | Fri, 6 Sep 2019 18:20:15 +0100 |
| |
On 06/09/2019 17:00, Arnd Bergmann wrote: > On Fri, Sep 6, 2019 at 5:55 PM Andrew Cooper <andrew.cooper3@citrix.com> wrote: >> On 06/09/2019 16:39, Arnd Bergmann wrote: >>> HYPERVISOR_platform_op() is an inline function and should not >>> be exported. Since commit 15bfc2348d54 ("modpost: check for >>> static EXPORT_SYMBOL* functions"), this causes a warning: >>> >>> WARNING: "HYPERVISOR_platform_op" [vmlinux] is a static EXPORT_SYMBOL_GPL >>> >>> Remove the extraneous export. >>> >>> Fixes: 15bfc2348d54 ("modpost: check for static EXPORT_SYMBOL* functions") >>> Signed-off-by: Arnd Bergmann <arnd@arndb.de> >> Something is wonky. That symbol is (/ really ought to be) in the >> hypercall page and most definitely not inline. >> >> Which tree is that changeset from? I can't find the SHA. > This is from linux-next, I think from the kbuild tree.
Thanks.
Julien/Stefano: Why are any of these hypercalls out-of-line? ARM doesn't use the hypercall page, and there is no argument translation (not even in arm32 as there are no 5-argument hypercalls declared).
They'd surely be easier to implement with a few static inlines and some common code, than to try and replicate the x86 side hypercall_page interface ?
~Andrew
| |