Messages in this thread | | | Date | Fri, 6 Sep 2019 17:08:28 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] Bluetooth: hidp: Fix error checks in hidp_get/set_raw_report |
| |
On Fri, Sep 06, 2019 at 03:56:29PM +0200, Marcel Holtmann wrote: > Hi Dan, > > > Commit 48d9cc9d85dd ("Bluetooth: hidp: Let hidp_send_message return > > number of queued bytes") changed hidp_send_message to return non-zero > > values on success, which some other bits did not expect. This caused > > spurious errors to be propagated through the stack, breaking some (all?) > > drivers, such as hid-sony for the Dualshock 4 in Bluetooth mode. > > > > Signed-off-by: Dan Elkouby <streetwalkermc@gmail.com> > > --- > > net/bluetooth/hidp/core.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > patch has been applied to bluetooth-next tree. >
The v2 added an additional fix and used the Fixes tag. Could you apply that instead?
regards, dan carpenter
| |