Messages in this thread | | | From | Krzysztof Kozlowski <> | Date | Fri, 6 Sep 2019 12:56:42 +0200 | Subject | Re: [PATCH 3/3] dt-bindings: ddr: Add bindings for Samsung LPDDR3 memories |
| |
On Fri, 6 Sep 2019 at 12:14, Lukasz Luba <l.luba@partner.samsung.com> wrote: > > Add description of bindings for Samsung k3qf2f20db LPDDR3 memory. > Minor fixes in the old documentation. > > Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com> > --- > .../devicetree/bindings/ddr/lpddr3.txt | 29 +++++++++++++++++-- > 1 file changed, 27 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/ddr/lpddr3.txt b/Documentation/devicetree/bindings/ddr/lpddr3.txt > index 3b2485b84b3f..de0905239767 100644 > --- a/Documentation/devicetree/bindings/ddr/lpddr3.txt > +++ b/Documentation/devicetree/bindings/ddr/lpddr3.txt > @@ -40,10 +40,34 @@ Child nodes: > a given speed-bin. Please see Documentation/devicetree/ > bindings/ddr/lpddr3-timings.txt for more information on "lpddr3-timings" > > +Samsung K3QF2F20DB LPDDR3 memory > +------------------------------------------------------------ > + > +This binding uses the LPDDR3 binding (described above) > + > +Required properties: > +- compatible: Should be: > + "samsung,K3QF2F20DB" > + followed by "jedec,lpddr3" > +- density : <u32> representing density in Mb (Mega bits) > +- io-width : <u32> representing bus width. Possible value 32 > +- #address-cells: Must be set to 1 > +- #size-cells: Must be set to 0
If you decided to repeat all properties again, then it deserves its own bindings file. However I though about simpler solution - just document compatible. Exactly the same as AT24 or AT25 EEPROM bindings. There is not much benefit from copying all these properties.
Best regards, Krzysztof
| |