Messages in this thread | | | Date | Fri, 6 Sep 2019 07:09:56 +0200 (CEST) | From | Julia Lawall <> | Subject | Re: [PATCH -next] coccinelle: platform_get_irq: Fix parse error |
| |
On Fri, 6 Sep 2019, YueHaibing wrote:
> When do coccicheck, I get this error: > > spatch -D report --no-show-diff --very-quiet --cocci-file > ./scripts/coccinelle/api/platform_get_irq.cocci --include-headers > --dir . -I ./arch/x86/include -I ./arch/x86/include/generated -I ./include > -I ./arch/x86/include/uapi -I ./arch/x86/include/generated/uapi > -I ./include/uapi -I ./include/generated/uapi > --include ./include/linux/kconfig.h --jobs 192 --chunksize 1 > minus: parse error: > File "./scripts/coccinelle/api/platform_get_irq.cocci", line 24, column 9, charpos = 355 > around = '\(', > whole content = if ( ret \( < \| <= \) 0 ) > > In commit e56476897448 ("fpga: Remove dev_err() usage > after platform_get_irq()") log, I found the semantic patch, > it fix this issue.
Thanks very much for reporting the problem.
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> > Fixes: 98051ba2b28b ("coccinelle: Add script to check for platform_get_irq() excessive prints") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > scripts/coccinelle/api/platform_get_irq.cocci | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/scripts/coccinelle/api/platform_get_irq.cocci b/scripts/coccinelle/api/platform_get_irq.cocci > index f6e1afc..06b6a95 100644 > --- a/scripts/coccinelle/api/platform_get_irq.cocci > +++ b/scripts/coccinelle/api/platform_get_irq.cocci > @@ -21,7 +21,7 @@ platform_get_irq > platform_get_irq_byname > )(E, ...); > > -if ( ret \( < \| <= \) 0 ) > +if ( \( ret < 0 \| ret <= 0 \) ) > { > ( > if (ret != -EPROBE_DEFER) > @@ -47,7 +47,7 @@ platform_get_irq > platform_get_irq_byname > )(E, ...); > > -if ( ret \( < \| <= \) 0 ) > +if ( \( ret < 0 \| ret <= 0 \) ) > { > ( > -if (ret != -EPROBE_DEFER) > @@ -74,7 +74,7 @@ platform_get_irq > platform_get_irq_byname > )(E, ...); > > -if ( ret \( < \| <= \) 0 ) > +if ( \( ret < 0 \| ret <= 0 \) ) > { > ( > if (ret != -EPROBE_DEFER) > -- > 2.7.4 > > >
| |