Messages in this thread Patch in this message | | | From | Colin King <> | Subject | [PATCH] input: sidewinder: make array seq static const, makes object smaller | Date | Thu, 5 Sep 2019 18:36:55 +0100 |
| |
From: Colin Ian King <colin.king@canonical.com>
Don't populate the array seq on the stack but instead make it static const. Makes the object code smaller by 30 bytes.
Before: text data bss dec hex filename 22284 3184 0 25468 637c drivers/input/joystick/sidewinder.o
After: text data bss dec hex filename 22158 3280 0 25438 635e drivers/input/joystick/sidewinder.o
(gcc version 9.2.1, amd64)
Signed-off-by: Colin Ian King <colin.king@canonical.com> --- drivers/input/joystick/sidewinder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/joystick/sidewinder.c b/drivers/input/joystick/sidewinder.c index 0284da874a2b..1777e68c9f02 100644 --- a/drivers/input/joystick/sidewinder.c +++ b/drivers/input/joystick/sidewinder.c @@ -223,7 +223,7 @@ static __u64 sw_get_bits(unsigned char *buf, int pos, int num, char bits) static void sw_init_digital(struct gameport *gameport) { - int seq[] = { 140, 140+725, 140+300, 0 }; + static const int seq[] = { 140, 140+725, 140+300, 0 }; unsigned long flags; int i, t; -- 2.20.1
| |