lkml.org 
[lkml]   [2019]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] pinctrl: bcm: remove redundant assignment to pointer log
From
Date


On 9/5/19 7:09 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer log is being initialized with a value that is never read
> and is being re-assigned a little later on. The assignment is
> redundant and hence can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/pinctrl/bcm/pinctrl-cygnus-mux.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pinctrl/bcm/pinctrl-cygnus-mux.c b/drivers/pinctrl/bcm/pinctrl-cygnus-mux.c
> index 44df35942a43..dcab2204c60c 100644
> --- a/drivers/pinctrl/bcm/pinctrl-cygnus-mux.c
> +++ b/drivers/pinctrl/bcm/pinctrl-cygnus-mux.c
> @@ -923,7 +923,6 @@ static int cygnus_mux_log_init(struct cygnus_pinctrl *pinctrl)
> if (!pinctrl->mux_log)
> return -ENOMEM;
>
> - log = pinctrl->mux_log;

Yes, this indeed looks completely redundant.

> for (i = 0; i < CYGNUS_NUM_IOMUX_REGS; i++) {
> for (j = 0; j < CYGNUS_NUM_MUX_PER_REG; j++) {
> log = &pinctrl->mux_log[i * CYGNUS_NUM_MUX_PER_REG
>

Change looks good to me. Thanks!

Reviewed-by: Ray Jui <ray.jui@broadcom.com>

\
 
 \ /
  Last update: 2019-09-05 18:47    [W:0.042 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site