lkml.org 
[lkml]   [2019]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 1/6] posix-cpu-timers: Always clear head pointer on dequeue
    On Thu, Sep 05, 2019 at 02:03:40PM +0200, Thomas Gleixner wrote:
    > The head pointer in struct cpu_timer is checked to be NULL in
    > posix_cpu_timer_del() when the delete raced with the exit cleanup. The
    > works correctly as long as the timer is actually dequeued via
    > posix_cpu_timers_exit*().
    >
    > But if the timer was dequeued due to expiry the head pointer is still set
    > and triggers the warning.
    >
    > In fact keeping the head pointer around after any dequeue is pointless as
    > is has no meaning at all after that.
    >
    > Clear the head pointer always on dequeue and remove the unused requeue
    > function while at it.
    >
    > Fixes: 60bda037f1dd ("posix-cpu-timers: Utilize timerqueue for storage")
    > Reported-by: syzbot+55acd54b57bb4b3840a4@syzkaller.appspotmail.com
    > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

    Reviewed-by: Frederic Weisbecker <frederic@kernel.org>

    \
     
     \ /
      Last update: 2019-09-05 17:51    [W:4.487 / U:0.244 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site