lkml.org 
[lkml]   [2019]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] soundwire: slave: Fix unused function warning on !ACPI
On 04-09-19, 12:48, Michal Suchánek wrote:
> On Wed, 4 Sep 2019 15:00:52 +0530
> Vinod Koul <vkoul@kernel.org> wrote:
>
> > On 30-08-19, 11:56, Randy Dunlap wrote:
> > > On 8/30/19 11:52 AM, Michal Suchanek wrote:
> > > > Fixes the following warning on !ACPI systems:
> > > >
> > > > drivers/soundwire/slave.c:16:12: warning: ‘sdw_slave_add’ defined but
> > > > not used [-Wunused-function]
> > > > static int sdw_slave_add(struct sdw_bus *bus,
> > > > ^~~~~~~~~~~~~
> > > >
> > > > Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> > >
> > > Acked-by: Randy Dunlap <rdunlap@infradead.org>
> > >
> > > I was about to send the same patch.
> >
> > So I have applied Srini's patches which add DT support and they use
> > sdw_slave_add(). So next tomorrow should not see this error as it is now
> > used by DT parts as well.
> >
> > So dropping this patch
> >
>
> That should fix the issue for me. I wonder if !ACPI !DT platforms are
> still a thing.

Heh that should trigger this if we have one :D so should a lot more
which depend on some firmware!

--
~Vinod

\
 
 \ /
  Last update: 2019-09-04 13:42    [W:0.167 / U:10.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site