lkml.org 
[lkml]   [2019]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3] sched/core: Fix uclamp ABI bug, clean up and robustify sched_read_attr() ABI logic and code
From
Date
On 04/09/2019 12:39, Ingo Molnar wrote:
>
> * Dietmar Eggemann <dietmar.eggemann@arm.com> wrote:
>
>>> -v3 attached. Build and minimally boot tested.
>>>
>>> Thanks,
>>>
>>> Ingo
>>>
>>
>> This patch fixes the issue (almost).
>>
>> LTP's sched_getattr01 passes again. But IMHO the prio 'chrt -p $$'
>> should be 0 instead of -65536.
>
> Yeah, I forgot to zero-initialize the structure ...
>
> Does the attached -v4 work any better for you?

Yeah, looks better now.

# chrt -p $$
[ 258.245786] sched_attr_copy_to_user(): copied 48 bytes. (ksize: 56,
usize: 48)
pid 1635's current scheduling policy: SCHED_OTHER
pid 1635's current scheduling priority: 0

w/o the extra printk:

Tested-by: Dietmar Eggemann <dietmar.eggemann@arm.com>

\
 
 \ /
  Last update: 2019-09-04 12:56    [W:0.062 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site