Messages in this thread | | | Subject | Re: [PATCH v3] sched/core: Fix uclamp ABI bug, clean up and robustify sched_read_attr() ABI logic and code | From | Dietmar Eggemann <> | Date | Wed, 4 Sep 2019 12:55:33 +0200 |
| |
On 04/09/2019 12:39, Ingo Molnar wrote: > > * Dietmar Eggemann <dietmar.eggemann@arm.com> wrote: > >>> -v3 attached. Build and minimally boot tested. >>> >>> Thanks, >>> >>> Ingo >>> >> >> This patch fixes the issue (almost). >> >> LTP's sched_getattr01 passes again. But IMHO the prio 'chrt -p $$' >> should be 0 instead of -65536. > > Yeah, I forgot to zero-initialize the structure ... > > Does the attached -v4 work any better for you?
Yeah, looks better now.
# chrt -p $$ [ 258.245786] sched_attr_copy_to_user(): copied 48 bytes. (ksize: 56, usize: 48) pid 1635's current scheduling policy: SCHED_OTHER pid 1635's current scheduling priority: 0
w/o the extra printk:
Tested-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
| |