lkml.org 
[lkml]   [2019]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] x86/microcode: Add an option to reload microcode even if revision is unchanged
From
Date
On 9/3/19 12:46 PM, Borislav Petkov wrote:
>
>
> @@ -629,8 +639,12 @@ static ssize_t reload_store(struct device *dev,
> if (ret)
> return ret;
>
> - if (val != 1)
> + if (val == 2) {
> + add_taint(TAINT_CPU_OUT_OF_SPEC, LOCKDEP_STILL_OK);

Why do we need to taint kernel here? We are not making any changes.


> + return microcode_reload_late(apply_microcode_nocheck);
> + } else if (val != 1) {
> return size;
> + }
>
> tmp_ret = microcode_ops->request_microcode_fw(bsp, &microcode_pdev->dev, true);

This won't allow people to load from new microcode blob which I thought
was one of the objectives behind this new feature.

-boris



\
 
 \ /
  Last update: 2019-09-05 00:08    [W:0.086 / U:1.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site