lkml.org 
[lkml]   [2019]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/1] s390: vfio-ap: fix warning reset not completed
From
Date
On 03.09.19 15:36, Halil Pasic wrote:
> The intention seems to be to warn once when we don't wait enough for the
> reset to complete. Let's use the right retry counter to accomplish that
> semantic.
>
> Signed-off-by: Halil Pasic <pasic@linux.ibm.com>

Thanks applied.

I will let it sit in our tree for some days as I want to see if we actually
hit the WARN_ON now. So if there is an rc8 this will be part of the next
merge window, otherwise this will somewhat come later.
> ---
> drivers/s390/crypto/vfio_ap_ops.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/s390/crypto/vfio_ap_ops.c b/drivers/s390/crypto/vfio_ap_ops.c
> index 0604b49a4d32..5c0f53c6dde7 100644
> --- a/drivers/s390/crypto/vfio_ap_ops.c
> +++ b/drivers/s390/crypto/vfio_ap_ops.c
> @@ -1143,7 +1143,7 @@ int vfio_ap_mdev_reset_queue(unsigned int apid, unsigned int apqi,
> msleep(20);
> status = ap_tapq(apqn, NULL);
> }
> - WARN_ON_ONCE(retry <= 0);
> + WARN_ON_ONCE(retry2 <= 0);
> return 0;
> case AP_RESPONSE_RESET_IN_PROGRESS:
> case AP_RESPONSE_BUSY:
>

\
 
 \ /
  Last update: 2019-09-04 09:26    [W:0.065 / U:5.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site