lkml.org 
[lkml]   [2019]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4.4 06/77] ASoC: Fail card instantiation if DAI format setup fails
    On Wed, Sep 04, 2019 at 07:52:53PM +0200, Greg Kroah-Hartman wrote:
    > [ Upstream commit 40aa5383e393d72f6aa3943a4e7b1aae25a1e43b ]
    >
    > If the DAI format setup fails, there is no valid communication format
    > between CPU and CODEC, so fail card instantiation, rather than continue
    > with a card that will most likely not function properly.

    I nacked this patch when Sasha posted it - it only improves diagnostics
    and might make systems that worked by accident break since it turns
    things into a hard failure, it won't make anything that didn't work
    previously work.
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2019-09-04 20:20    [W:4.162 / U:0.280 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site