lkml.org 
[lkml]   [2019]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.2 001/143] dmaengine: ste_dma40: fix unneeded variable warning
    Date
    [ Upstream commit 5d6fb560729a5d5554e23db8d00eb57cd0021083 ]

    clang-9 points out that there are two variables that depending on the
    configuration may only be used in an ARRAY_SIZE() expression but not
    referenced:

    drivers/dma/ste_dma40.c:145:12: error: variable 'd40_backup_regs' is not needed and will not be emitted [-Werror,-Wunneeded-internal-declaration]
    static u32 d40_backup_regs[] = {
    ^
    drivers/dma/ste_dma40.c:214:12: error: variable 'd40_backup_regs_chan' is not needed and will not be emitted [-Werror,-Wunneeded-internal-declaration]
    static u32 d40_backup_regs_chan[] = {

    Mark these __maybe_unused to shut up the warning.

    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
    Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
    Link: https://lore.kernel.org/r/20190712091357.744515-1-arnd@arndb.de
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/dma/ste_dma40.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
    index 89d710899010d..de8bfd9a76e9e 100644
    --- a/drivers/dma/ste_dma40.c
    +++ b/drivers/dma/ste_dma40.c
    @@ -142,7 +142,7 @@ enum d40_events {
    * when the DMA hw is powered off.
    * TODO: Add save/restore of D40_DREG_GCC on dma40 v3 or later, if that works.
    */
    -static u32 d40_backup_regs[] = {
    +static __maybe_unused u32 d40_backup_regs[] = {
    D40_DREG_LCPA,
    D40_DREG_LCLA,
    D40_DREG_PRMSE,
    @@ -211,7 +211,7 @@ static u32 d40_backup_regs_v4b[] = {

    #define BACKUP_REGS_SZ_V4B ARRAY_SIZE(d40_backup_regs_v4b)

    -static u32 d40_backup_regs_chan[] = {
    +static __maybe_unused u32 d40_backup_regs_chan[] = {
    D40_CHAN_REG_SSCFG,
    D40_CHAN_REG_SSELT,
    D40_CHAN_REG_SSPTR,
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-09-04 20:10    [W:2.220 / U:0.388 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site