Messages in this thread | | | Date | Tue, 1 Oct 2019 04:33:01 +0200 | From | Christian Brauner <> | Subject | Re: [PATCH v4 3/4] sched_setattr: switch to copy_struct_from_user() |
| |
On Tue, Oct 01, 2019 at 11:10:54AM +1000, Aleksa Sarai wrote: > The change is very straightforward, and helps unify the syscall > interface for struct-from-userspace syscalls. Ideally we could also > unify sched_getattr(2)-style syscalls as well, but unfortunately the > correct semantics for such syscalls are much less clear (see [1] for > more detail). In future we could come up with a more sane idea for how > the syscall interface should look. > > [1]: commit 1251201c0d34 ("sched/core: Fix uclamp ABI bug, clean up and > robustify sched_read_attr() ABI logic and code") > > Reviewed-by: Kees Cook <keescook@chromium.org> > Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Reviewed-by: Christian Brauner <christian.brauner@ubuntu.com>
| |