Messages in this thread | | | From | Linus Walleij <> | Date | Mon, 30 Sep 2019 23:56:50 +0200 | Subject | Re: [PATCH] net: dsa: rtl8366rb: add missing of_node_put after calling of_get_child_by_name |
| |
On Sun, Sep 29, 2019 at 9:01 AM Wen Yang <wenyang@linux.alibaba.com> wrote:
It's nice to see some Alibaba kernel contributions!
> of_node_put needs to be called when the device node which is got > from of_get_child_by_name finished using. > irq_domain_add_linear() also calls of_node_get() to increase refcount, > so irq_domain will not be affected when it is released. > > fixes: d8652956cf37 ("net: dsa: realtek-smi: Add Realtek SMI driver") > Signed-off-by: Wen Yang <wenyang@linux.alibaba.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Andrew Lunn <andrew@lunn.ch> > Cc: Vivien Didelot <vivien.didelot@gmail.com> > Cc: Florian Fainelli <f.fainelli@gmail.com> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: netdev@vger.kernel.org > Cc: linux-kernel@vger.kernel.org
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij
| |