Messages in this thread | | | Date | Sun, 29 Sep 2019 16:57:58 +0200 | From | Greg KH <> | Subject | Re: [PATCH 1/3] Staging: exfat: exfat_super.c: fixed camelcase coding style issue |
| |
On Sun, Sep 29, 2019 at 09:50:57AM -0500, Jesse Barton wrote: > Changed function names: > ffsUmountVol to ffs_umount_vol > ffsMountVol to ffs_mount_vol > ffsSyncVol to ffs_sync_vol > >
That says _what_ you did, but not _why_ you are doing this.
And is this really the best name for these functions? Why the ffs_* prefix?
Also, you didn't include the maintainer again, and you didn't thread your emails using 'git send-email' :(
And finally, you sent a new version of the patch, but did not "version" it, saying what changed from the previous version. The documentation says how to do this, so you might want to re-read that.
Can you please fix this all up and resend the series as "v3"?
thanks,
greg k-h
| |