Messages in this thread Patch in this message | | | From | zhong jiang <> | Subject | [PATCH] fs: omfs: Use kmemdup rather than duplicating its implementation in omfs_get_imap | Date | Tue, 3 Sep 2019 14:39:44 +0800 |
| |
kmemdup contains the kmalloc + memcpy. hence it is better to use kmemdup directly. Just replace it.
Signed-off-by: zhong jiang <zhongjiang@huawei.com> --- fs/omfs/inode.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/omfs/inode.c b/fs/omfs/inode.c index b76ec6b..8867cef 100644 --- a/fs/omfs/inode.c +++ b/fs/omfs/inode.c @@ -363,12 +363,11 @@ static int omfs_get_imap(struct super_block *sb) bh = sb_bread(sb, block++); if (!bh) goto nomem_free; - *ptr = kmalloc(sb->s_blocksize, GFP_KERNEL); + *ptr = kmemdup(bh->b_data, sb->s_blocksize, GFP_KERNEL); if (!*ptr) { brelse(bh); goto nomem_free; } - memcpy(*ptr, bh->b_data, sb->s_blocksize); if (count < sb->s_blocksize) memset((void *)*ptr + count, 0xff, sb->s_blocksize - count); -- 1.7.12.4
| |