lkml.org 
[lkml]   [2019]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 00/13] virtio-fs: shared file system for virtual machines
On Tue, Sep 03, 2019 at 10:07:52AM -0400, Vivek Goyal wrote:
> On Tue, Sep 03, 2019 at 04:31:38AM -0400, Michael S. Tsirkin wrote:
>
> [..]
> > + /* TODO lock */
> > give me pause.
> >
> > Cleanup generally seems broken to me - what pauses the FS
>
> I am looking into device removal aspect of it now. Thinking of adding
> a reference count to virtiofs device and possibly also a bit flag to
> indicate if device is still alive. That way, we should be able to cleanup
> device more gracefully.

Generally, the way to cleanup things is to first disconnect device from
linux so linux won't send new requests, wait for old ones to finish.




> >
> > What about the rest of TODOs in that file?
>
> I will also take a closer look at TODOs now. Better device cleanup path
> might get rid of some of them. Some of them might not be valid anymore.
>
> >
> > use of usleep is hacky - can't we do better e.g. with a
> > completion?
>
> Agreed.
>
> Thanks
> Vivek

\
 
 \ /
  Last update: 2019-09-03 16:12    [W:0.159 / U:1.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site