Messages in this thread | | | Date | Tue, 3 Sep 2019 08:15:24 +0200 | From | Gerd Hoffmann <> | Subject | Re: [PATCH 1/5] drm/ttm: add drm_gem_ttm_print_info() |
| |
Hi,
> > + [ TTM_PL_SYSTEM ] = "system", > > + [ TTM_PL_TT ] = "tt", > > + [ TTM_PL_VRAM ] = "vram", > > + [ TTM_PL_PRIV ] = "priv", > > + > > This 'gap' in the array seems to be a problem for drivers that use these > bits. Could the print logic be moved into s separate function that also > takes the array as an argument?
Are there any drivers which actually use these bits and which therefore might want to use a different array?
Also note they should not cause any problems (other than not being printed). There is an explicit check here ...
> > + if (!plname[i]) > > + continue;
.. to skip unknown bits.
cheers, Gerd
| |