Messages in this thread | | | Date | Fri, 27 Sep 2019 20:18:37 +0200 | From | Stephen Kitt <> | Subject | Re: [PATCH v2] clk/ti/adpll: allocate room for terminating null |
| |
Le 27/09/2019 20:05, Stephen Kitt a écrit : > The buffer allocated in ti_adpll_clk_get_name doesn't account for the > terminating null. This patch switches to ka_sprintf to avoid
Aargh, devm_kasprintf of course...
> overflowing. > > Signed-off-by: Stephen Kitt <steve@sk2.org> > --- > drivers/clk/ti/adpll.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/clk/ti/adpll.c b/drivers/clk/ti/adpll.c > index fdfb90058504..021cf9e2b4db 100644 > --- a/drivers/clk/ti/adpll.c > +++ b/drivers/clk/ti/adpll.c > @@ -195,14 +195,8 @@ static const char *ti_adpll_clk_get_name(struct > ti_adpll_data *d, > return NULL; > } else { > const char *base_name = "adpll"; > - char *buf; > - > - buf = devm_kzalloc(d->dev, 8 + 1 + strlen(base_name) + 1 + > - strlen(postfix), GFP_KERNEL); > - if (!buf) > - return NULL; > - sprintf(buf, "%08lx.%s.%s", d->pa, base_name, postfix); > - name = buf; > + name = devm_kasprintf(d->dev, GFP_KERNEL, "%08lx.%s.%s", > + d->pa, base_name, postfix); > } > > return name;
| |