lkml.org 
[lkml]   [2019]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] staging: rtl8192u: fix multiple memory leaks on error path
From
Date
> In rtl8192_tx on error handling path allocated urbs and also skb should
> be released.

Can this change description be improved?


How do you think about to add the tag “Fixes” here?


> @@ -1588,7 +1590,12 @@ short rtl8192_tx(struct net_device *dev, struct sk_buff *skb)
> RT_TRACE(COMP_ERR, "Error TX URB %d, error %d",
> atomic_read(&priv->tx_pending[tcb_desc->queue_index]),
> status);
> - return -1;
> +
> +error:
> + dev_kfree_skb_any(skb);


Would an other label be more appropriate according to the Linux coding style?

Regards,
Markus

\
 
 \ /
  Last update: 2019-09-27 18:10    [W:0.052 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site