Messages in this thread | | | Subject | Re: [PATCH] i40e: prevent memory leak in i40e_setup_macvlans | From | Markus Elfring <> | Date | Fri, 27 Sep 2019 17:04:45 +0200 |
| |
> In i40e_setup_macvlans if i40e_setup_channel fails the allocated memory > for ch should be released.
I suggest to improve also this change description.
> +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c > @@ -7168,6 +7168,7 @@ static int i40e_setup_macvlans(struct i40e_vsi *vsi, u16 macvlan_cnt, u16 qcnt, > ch->num_queue_pairs = qcnt; > if (!i40e_setup_channel(pf, vsi, ch)) { > ret = -EINVAL; > + kfree(ch); > goto err_free; > } > ch->parent_vsi = vsi;
Can it matter to perform the added function call before the error code assignment?
Regards, Markus
| |