lkml.org 
[lkml]   [2019]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] checkpatch: Warn if DT bindings are not in schema format
From
Date
On Fri, 2019-09-27 at 09:02 -0500, Rob Herring wrote:
> On Fri, Sep 13, 2019 at 4:48 PM Joe Perches <joe@perches.com> wrote:
> > On Fri, 2019-09-13 at 16:13 -0500, Rob Herring wrote:
> > > DT bindings are moving to using a json-schema based schema format
> > > instead of freeform text. Add a checkpatch.pl check to encourage using
> > > the schema for new bindings. It's not yet a requirement, but is
> > > progressively being required by some maintainers.
> > []
> > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > []
> > > @@ -2822,6 +2822,14 @@ sub process {
> > > "added, moved or deleted file(s), does MAINTAINERS need updating?\n" . $herecurr);
> > > }
> > >
> > > +# Check for adding new DT bindings not in schema format
> > > + if (!$in_commit_log &&
> > > + ($line =~ /^new file mode\s*\d+\s*$/) &&
> > > + ($realfile =~ m@^Documentation/devicetree/bindings/.*\.txt$@)) {
> > > + WARN("DT_SCHEMA_BINDING_PATCH",
> > > + "DT bindings should be in DT schema format. See: Documentation/devicetree/writing-schema.rst\n");
> > > + }
> > > +
> >
> > As this already seems to be git dependent, perhaps
>
> It's quite rare to see a non git generated diff these days.
>
> > it's easier to read with a single line test like:
> >
> > if ($line =~ m{^\s*create mode\s*\d+\s*Documentation/devicetree/bindings/.*\.txt$}) {
> > etc...
> > }
>
> I frequently do 'git show $commit | scripts/checkpatch.pl' and this
> doesn't work with that. I really should have a '--pretty=email' in
> there, but I just ignore the commit msg warnings. In any case, that
> still doesn't help because there's no diffstat. There's probably some
> way to turn that on or just use git-format-patch, but really we want
> this to work with any git diff.

I don't understand your argument against what I proposed at all.

and btw:

$ git format-patch -1 --stdout <commit> | ./scripts/checkpatch.pl


\
 
 \ /
  Last update: 2019-09-27 16:30    [W:0.061 / U:7.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site