lkml.org 
[lkml]   [2019]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] nubus: remove cast to void pointer
Hi Himanshu,

On Sun, Aug 27, 2017 at 9:33 AM Himanshu Jha
<himanshujha199640@gmail.com> wrote:
> Casting void pointers to other pointer types in unnecessary.
>
> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>

Thanks for your patch!

> --- a/drivers/nubus/nubus.c
> +++ b/drivers/nubus/nubus.c
> @@ -167,7 +167,7 @@ static unsigned char *nubus_dirptr(const struct nubus_dirent *nd)
> void nubus_get_rsrc_mem(void *dest, const struct nubus_dirent *dirent,
> int len)
> {
> - unsigned char *t = (unsigned char *)dest;
> + unsigned char *t = dest;
> unsigned char *p = nubus_dirptr(dirent);
>
> while (len) {
> @@ -180,7 +180,7 @@ EXPORT_SYMBOL(nubus_get_rsrc_mem);
> void nubus_get_rsrc_str(void *dest, const struct nubus_dirent *dirent,
> int len)
> {
> - unsigned char *t = (unsigned char *)dest;
> + unsigned char *t = dest;
> unsigned char *p = nubus_dirptr(dirent);
>
> while (len) {

The second chunk is no longer valid, but the first one still is.

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
i.e. will queue the first chunk for v5.5.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

\
 
 \ /
  Last update: 2019-09-27 14:46    [W:0.027 / U:33.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site